Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][ADD] shopfloor_reception_purchase_partner_ref #605

Merged
merged 4 commits into from
Aug 23, 2023
Merged

[14.0][ADD] shopfloor_reception_purchase_partner_ref #605

merged 4 commits into from
Aug 23, 2023

Conversation

mt-software-de
Copy link
Contributor

@mt-software-de mt-software-de commented Mar 15, 2023 •
edited
Loading

No description provided.

@OCA-git-bot
Copy link
Contributor

Hi @JuMiSanAr,
some modules you are maintaining are being modified, check this out!

@simahawk simahawk changed the title 14.0 add shopfloor reception purchase partner ref [14.0][ADD] shopfloor_reception_purchase_partner_ref May 18, 2023
@simahawk
Copy link
Contributor

One more thing: I'd recommend to move the the schange on the shopfloor_reception_mobile to another PR to speed its merge and to be able to bump version on merge.

@mt-software-de mt-software-de force-pushed the 14.0-add-shopfloor_reception_purchase_partner_ref branch 3 times, most recently from 84e3b39 to d6643bc Compare July 10, 2023 19:24
@mt-software-de mt-software-de requested a review from simahawk July 19, 2023 07:30
@mt-software-de
Copy link
Contributor Author

@jbaudoux could you please review this PR?

@mt-software-de mt-software-de force-pushed the 14.0-add-shopfloor_reception_purchase_partner_ref branch from d6643bc to 1374a6e Compare July 19, 2023 09:40
@mt-software-de mt-software-de force-pushed the 14.0-add-shopfloor_reception_purchase_partner_ref branch 2 times, most recently from 3e24c4e to 46ae01a Compare July 25, 2023 20:56
@mt-software-de mt-software-de force-pushed the 14.0-add-shopfloor_reception_purchase_partner_ref branch 3 times, most recently from 66ccef1 to f1b0e3a Compare August 15, 2023 11:49
@mt-software-de mt-software-de force-pushed the 14.0-add-shopfloor_reception_purchase_partner_ref branch 3 times, most recently from d53c992 to 90a4f97 Compare August 16, 2023 12:49
simahawk
simahawk reviewed Aug 17, 2023
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG.
@mt-software-de can you please shorten commit msgs and keep descriptions into the commit description?

@mt-software-de mt-software-de force-pushed the 14.0-add-shopfloor_reception_purchase_partner_ref branch from 90a4f97 to 74f79b4 Compare August 17, 2023 09:39
@mt-software-de
[ADD] shopfloor_purchase_base: Purchase order data on picking
c1b3b5f 
Add optional purchase order data to picking data
To get the purchase order within the picking data
call data.picking with kwarg with_purchase_order
@mt-software-de mt-software-de force-pushed the 14.0-add-shopfloor_reception_purchase_partner_ref branch 2 times, most recently from b762fc7 to 302c655 Compare August 17, 2023 09:43
@mt-software-de
Copy link
Contributor Author

LG. @mt-software-de can you please shorten commit msgs and keep descriptions into the commit description?

Done

@simahawk
Copy link
Contributor

@mt-software-de the last commit is still too long but in fact you don't need any additional info beside [add] $module_name 😉

@mt-software-de
[ADD] shopfloor_reception_purchase_partner_ref
4c416bb 
Show the partner_ref field of a purchase order on the reception scenario
@mt-software-de mt-software-de force-pushed the 14.0-add-shopfloor_reception_purchase_partner_ref branch from 302c655 to 4c416bb Compare August 17, 2023 11:06
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@jbaudoux
Copy link
Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-605-by-jbaudoux-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Aug 23, 2023
@OCA-git-bot
Merge PR #605 into 14.0
8ce2376 
Signed-off-by jbaudoux
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 14.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-605-by-jbaudoux-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Aug 23, 2023
@OCA-git-bot
Merge PR #605 into 14.0
ad3271c 
Signed-off-by jbaudoux
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 14.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-605-by-jbaudoux-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Aug 23, 2023
@OCA-git-bot
Merge PR #605 into 14.0
b8a82e8 
Signed-off-by jbaudoux
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 14.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-605-by-jbaudoux-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Aug 23, 2023
@OCA-git-bot
Merge PR #605 into 14.0
2354356 
Signed-off-by jbaudoux
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 14.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-605-by-jbaudoux-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c07207d into OCA:14.0 Aug 23, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 86c74f8. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbaudoux jbaudoux jbaudoux approved these changes

@simahawk simahawk simahawk approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mt-software-de @OCA-git-bot @simahawk @jbaudoux